Skip to content

🎨 Extends list_projects_marked_as_jobs in the webserver's rpc API #7577

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 10 commits into from
Apr 25, 2025
Merged

🎨 Extends list_projects_marked_as_jobs in the webserver's rpc API #7577

merged 10 commits into from
Apr 25, 2025

Conversation

@pcrespov
Copy link
Member

@pcrespov pcrespov commented Apr 24, 2025 •
edited
Loading

What do these changes do?

  • 🎨 Extends the schema ProjectJobRpcGet returned list_projects_marked_as_jobs in the webserver's rpc API.
  • ♻️ Improved rpc fakes
  • ♻️ Updated fields to Annotated types

Related issue/s

How to test

cd services/web/server
make install-dev
pytest -vv tests/unit/**/test_projects_rpc.py

Dev-ops

None

@pcrespov pcrespov self-assigned this Apr 24, 2025
@pcrespov pcrespov added this to the Pauwel Kwak milestone Apr 24, 2025
@codecov
Copy link

codecov bot commented Apr 24, 2025 •
edited
Loading

Codecov Report

Attention: Patch coverage is 87.17949% with 5 lines in your changes missing coverage. Please review.

Project coverage is 87.73%. Comparing base (fb26261) to head (6c85f63).
Report is 1 commits behind head on master.

Additional details and impacted files 
@@            Coverage Diff             @@
##           master    #7577      +/-   ##
==========================================
+ Coverage   87.68%   87.73%   +0.05%     
==========================================
  Files        1774     1767       -7     
  Lines       68413    68236     -177     
  Branches     1125     1125              
==========================================
- Hits        59985    59869     -116     
+ Misses       8121     8061      -60     
+ Partials      307      306       -1
Flag Coverage Δ
integrationtests 65.18% <75.00%> (+0.01%) ⬆️
unittests 86.92% <87.17%> (+0.05%) ⬆️
Components Coverage Δ
api ∅ <ø> (∅)
pkg_aws_library 93.91% <ø> (ø)
pkg_dask_task_models_library 97.10% <ø> (ø)
pkg_models_library 92.72% <93.75%> (+0.01%) ⬆️
pkg_notifications_library 85.26% <ø> (ø)
pkg_postgres_database 88.18% <ø> (ø)
pkg_service_integration 69.92% <ø> (ø)
pkg_service_library 72.95% <0.00%> (ø)
pkg_settings_library 90.90% <ø> (ø)
pkg_simcore_sdk 85.78% <ø> (+0.29%) ⬆️
agent 96.46% <ø> (ø)
api_server 91.27% <ø> (ø)
autoscaling 96.08% <ø> (ø)
catalog 92.64% <ø> (ø)
clusters_keeper 99.25% <ø> (ø)
dask_sidecar 91.29% <ø> (ø)
datcore_adapter 98.12% <ø> (ø)
director 76.89% <ø> (ø)
director_v2 91.38% <ø> (ø)
dynamic_scheduler 97.40% <ø> (ø)
dynamic_sidecar 90.15% <ø> (ø)
efs_guardian 89.79% <ø> (ø)
invitations 93.28% <ø> (ø)
payments 92.66% <ø> (ø)
resource_usage_tracker 89.12% <ø> (-0.17%) ⬇️
storage 87.49% <ø> (ø)
webclient ∅ <ø> (∅)
webserver 86.12% <100.00%> (+0.07%) ⬆️

Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fb26261...6c85f63. Read the comment docs.

🚀 New features to boost your workflow:
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@pcrespov pcrespov requested a review from Copilot April 24, 2025 13:04
Copilot AI reviewed Apr 24, 2025
View reviewed changes
Copy link
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

This PR extends the webserver’s RPC API schema for job‐based projects by renaming data models and updating the payload to include workbench details. Key changes include:

  • Replacing the ProjectRpcGet model with the new ProjectJobRpcGet in tests and API endpoints.
  • Adding and comparing a new workbench property in project payloads.
  • Adjusting timestamp field names and migrating repository queries and RPC interfaces accordingly.

Reviewed Changes

Copilot reviewed 12 out of 12 changed files in this pull request and generated 2 comments.

Show a summary per file
File Description
tests/unit/with_dbs/02/test_projects_rpc.py Updated to use ProjectJobRpcGet and added assertions for workbench fields.
tests/unit/with_dbs/02/test_projects__jobs_service.py Added fixture dependency and further asserts to verify workbench structure.
src/simcore_service_webserver/projects/models.py Extended ProjectJobDBGet to include workbench data.
src/simcore_service_webserver/projects/_projects_service.py Added a type ignore on NodeState update; minimal adjustments for RPC jobs.
src/simcore_service_webserver/projects/_controller/projects_rpc.py Changed return types and model creation to match ProjectJobRpcGet.
packages/* Updated RPC interfaces and models-library definitions to adopt the new Job RPC models and timestamp field renaming.

@pcrespov pcrespov changed the title 🎨 WIP: Is7399/updates rpc projects webserver 🎨 Extends list_projects_marked_as_jobs in the webserver's rpc API Apr 24, 2025
@pcrespov pcrespov added the a:webserver webserver's codebase. Assigning the area is particularly useful for bugs label Apr 24, 2025
@pcrespov pcrespov marked this pull request as ready for review April 24, 2025 13:11
@pcrespov pcrespov requested a review from bisgaard-itis April 24, 2025 13:11
bisgaard-itis
bisgaard-itis approved these changes Apr 24, 2025
View reviewed changes
Copy link
Contributor

@bisgaard-itis bisgaard-itis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you

GitHK
GitHK approved these changes Apr 24, 2025
View reviewed changes
@pcrespov pcrespov force-pushed the is7399/updates-rpc-projects-webserver branch from 9415df4 to af57c65 Compare April 24, 2025 14:26
@pcrespov pcrespov enabled auto-merge (squash) April 24, 2025 15:44
@pcrespov pcrespov added the 🤖-automerge marks PR as ready to be merged for Mergify label Apr 25, 2025
@pcrespov
Copy link
Member Author

pcrespov commented Apr 25, 2025

@mergify queue

@mergify
Copy link
Contributor

mergify bot commented Apr 25, 2025 •
edited
Loading

queue

🛑 The pull request has been removed from the queue default

The following conditions don't match anymore:

  • any of: [🔀 queue conditions]
    • all of: [📌 queue conditions of queue default]
      • any of: [🛡 GitHub branch protection]
        • check-neutral = deploy to dockerhub
        • check-skipped = deploy to dockerhub
        • check-success = deploy to dockerhub
      • any of: [🛡 GitHub branch protection]
        • check-neutral = system-tests
        • check-skipped = system-tests
        • check-success = system-tests
      • any of: [🛡 GitHub branch protection]
        • check-neutral = unit-tests
        • check-skipped = unit-tests
        • check-success = unit-tests
      • any of: [🛡 GitHub branch protection]
        • check-neutral = integration-tests
        • check-skipped = integration-tests
        • check-success = integration-tests

@sonarqubecloud
Copy link

sonarqubecloud bot commented Apr 25, 2025

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

@mergify
Copy link
Contributor

mergify bot commented Apr 25, 2025

This pull request has been removed from the queue for the following reason: checks failed.

The merge conditions cannot be satisfied due to failing checks:

You may have to fix your CI before adding the pull request to the queue again.
If you update this pull request, to fix the CI, it will automatically be requeued once the queue conditions match again.
If you think this was a flaky issue instead, you can requeue the pull request, without updating it, by posting a @mergifyio requeue comment.

@pcrespov pcrespov merged commit cb79d90 into ITISFoundation:master Apr 25, 2025
95 of 96 checks passed
@pcrespov pcrespov deleted the is7399/updates-rpc-projects-webserver branch April 25, 2025 12:56
@matusdrobuliak66 matusdrobuliak66 mentioned this pull request May 8, 2025
Closed
34 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

Copilot code review Copilot Copilot left review comments

@giancarloromeo giancarloromeo giancarloromeo approved these changes

@GitHK GitHK GitHK approved these changes

@sanderegg sanderegg sanderegg approved these changes

@matusdrobuliak66 matusdrobuliak66 matusdrobuliak66 approved these changes

@bisgaard-itis bisgaard-itis bisgaard-itis approved these changes

Assignees

@pcrespov pcrespov

Labels

🤖-automerge marks PR as ready to be merged for Mergify a:webserver webserver's codebase. Assigning the area is particularly useful for bugs

Projects

None yet

Milestone

Pauwel Kwak

Development

Successfully merging this pull request may close these issues.

6 participants

@pcrespov @giancarloromeo @GitHK @sanderegg @matusdrobuliak66 @bisgaard-itis